On 05/29/2012 05:19 PM, Tom Warren wrote:
On Tue, May 29, 2012 at 3:12 PM, Stephen Warren swarren@wwwdotorg.org wrote:
On 05/29/2012 03:47 PM, Lucas Stach wrote:
The RAM configuration is set by the bootrom to values specified by the BCT. To query the available RAM size of a board we can easily read back those values instead of using the hardcoded ODMdata. This allows for a single u-boot image on similar boards with different amount of RAM.
While this probably works fine (although I didn't read it in detail), the boot protocol is defined to work a little differently. U-Boot is supposed to read the BCT/BIT from the IRAM, and program PMC_SCRATCH20 with the ODMDATA, and then the rest of the bootloader and kernel can continue to use the fields in the ODMDATA as they currently do.
Tom, you wrote commit f22c431 "arm: Tegra: Use ODMDATA from BCT in IRAM" in our downstream tree for this. Are you planning on upstreaming it?
Eventually, yes. The nice thing about using a (flash) cmd-line variable ODMData is that you can vary things like RAM size, UART, etc. With Lucas' change, you get the fixed RAM size directly from the HW instead of the ODMDATA (which could be wrong, since it currently has no bearing on anything else in the BL code, and isn't checked against what's in the BCT/BIT that the BootROM used).
I don't quite understand. Doesn't the boot ROM read the ODMDATA in order to set up the EMC register that Lucas' change reads? Hmm. Perhaps not ODMDATA, but at least some field in the BCT. And when flashing, both the ODMDATA and the BCT are part of the flashing process.