Hi,
On 14-11-16 14:53, Maxime Ripard wrote:
On Mon, Nov 14, 2016 at 12:29:25PM +0100, Hans de Goede wrote:
Hi,
On 14-11-16 12:18, Hans de Goede wrote:
Hi,
On 08-11-16 17:21, Maxime Ripard wrote:
This program generates raw SPL images that can be flashed on the NAND with the ECC and randomizer properly set up.
Signed-off-by: Maxime Ripard maxime.ripard@free-electrons.com
Looks good to me:
Reviewed-by: Hans de Goede hdegoede@redhat.com
Note this causes a cpu_to_be32 redefine compiler warning I've fixed this up locally.
I'll have to send a v2 based on Tom's comments. How did you fix this?
I added an undef above the define, if you use the pre-existing macro you get problems later because it gets called as cpu_to_be32(*addr++) and the pre-existing macro references its argument multiple times.
Regards,
Hans