Hi Philipp,
On Mon, 2018-12-03 at 13:28 +0100, Philipp Tomsich wrote: Alexey,
On 03.12.2018, at 12:20, Alexey Brodkin <alexey.brodkin@synopsys.commailto:alexey.brodkin@synopsys.com> wrote: Hi Philipp,
On Fri, 2018-11-30 at 22:13 +0100, Philipp Tomsich wrote: The NAND driver of AXS10x depends on the availability of the bounce buffer. As the NAND driver is gated by CMD_NAND only, we need to select BOUNCE_BUFFER conditionally (on CMD_NAND) for TARGET_AXS101 and TARGET_AXS103.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.commailto:philipp.tomsich@theobroma-systems.com> ---
Changes in v3: None Changes in v2: None
arch/arc/Kconfig | 2 ++ include/configs/axs10x.h | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig index fa6b344..50369d5 100644 --- a/arch/arc/Kconfig +++ b/arch/arc/Kconfig @@ -146,9 +146,11 @@ config TARGET_NSIM
config TARGET_AXS101 bool "Support Synopsys Designware SDP board AXS101" + select BOUNCE_BUFFER if CMD_NAND
config TARGET_AXS103 bool "Support Synopsys Designware SDP board AXS103" + select BOUNCE_BUFFER if CMD_NAND
I'd say that more appropriate place is "board/synopsys/axs10x/Kconfig". Because: - This is related to the particular board, architecture has nothing to do with this - Only 1 line of change will be required as both boards use the same Kconfig file
Happily, if you tell me how I can add a ‘select’ for this config-option in board/synopsys/axs10x/Kconfig w/o unintended side-effects … In other words: I failed when I tried to override CMD_NAND in that file.
Ok I see now. We need to have either "bool" or "tristate" Kconfig entry to specify "select". So we'll need to introduce another hidden variable in board/synopsys/axs10x/Kconfig to get it working... in that case I think your initial proposal looks better.
Sorry for the noise then.
-Alexey