On Friday 05 February 2010 20:08:38 Ben Warren wrote:
On 2/5/2010 4:01 PM, Mike Frysinger wrote:
On Friday 05 February 2010 18:49:37 Alessandro Rubini wrote:
Older versions created symbolic links for e.g. crc32.c. If such link remains in a tree, current Makefiles will use CC instead of HOSTCC to compile it; this results in a linker error. To be safe, let's remove any link from earlier checkouts.
current policy is to run `git clean -x -d` after a `git pull`, but i dont care either way
--- a/Makefile +++ b/Makefile @[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l -print | xargs rm -f @[ ! -d $(obj)onenand_ipl ] || find $(obj)onenand_ipl -name "*" -type l -print | xargs rm -f @[ ! -d $(obj)tools ] || find $(obj)tools -name "*" -type l -print | xargs rm -f
not related directly to your patch, but these -name '*' are useless
also, why not just scan the entire tree: @[ ! -d $(obj) ] || find $(obj) -type l -print | xargs rm -f
And 'find' had a '-delete' switch. Not sure how long it's been there.
i didnt suggest that because it isnt POSIX. it'll break on BSD systems which typically ship with sh*t userland tools. -mike