Hi Wolfgang,
On Mon, May 21, 2012 at 2:14 AM, Wolfgang Denk wd@denx.de wrote:
Commit db288a9 "net: Remove volatile from net API" caused a number of build warnings: fec.c: In function 'fec_initialize': fec.c:183:13: warning: assignment from incompatible pointer type [enabled by default] fec.c: In function 'fec_recv': fec.c:284:5: warning: passing argument 1 of 'NetReceive' discards 'volatile' qualifier from pointer target type [enabled by default] /home/wd/git/u-boot/work/include/net.h:433:13: note: expected 'uchar *' but argument is of type 'volatile uchar *' scc.c: In function 'scc_initialize': scc.c:85:14: warning: assignment from incompatible pointer type [enabled by default]
Fix these.
Signed-off-by: Wolfgang Denk wd@denx.de Cc: Joe Hershberger joe.hershberger@ni.com
Joe, I started fixing these issues when I realized that this is not just a few files, but actually _ALL_ network drivers that you forgot to adapt. I wonder how much testing was done before you decided to pull this into mainline? It appears not much compile testing... what about run-time testing?
Sorry, but I don't have time to clean up all of this. Are you going to do that?
Applied this for a start.
Thanks, -Joe