Hi, Stefano,
2010/10/26 Stefano Babic sbabic@denx.de:
On 10/22/2010 01:25 PM, Jason Liu wrote:
The patch is to support getting FEC MAC address from fuse bank.
Signed-off-by: Jason Liu r64343@freescale.com
Hi Jason,
patch is related to a network driver, so Ben should be informed, too.
OK, I will resend the patch and cc Ben. Thanks for reminder. :)
- /*
- * The MX27 can store the mac address in internal eeprom
- * This mechanism is also supported now by MX51 or MX25
- */
If all supported processors implement the same way, we do not need to distinguish. The comment does not add any further info.
OK, will remove it.
struct iim_regs *iim = (struct iim_regs *)IMX_IIM_BASE; int i;
for (i = 0; i < 6; i++)
- mac[6-1-i] = readl(&iim->iim_bank_area0[IIM0_MAC + i]);
- mac[6-1-i] = readl(&iim->iim_bank_area[IIM_MAC + i]);
return !is_valid_ether_addr(mac); -#endif
}
static int fec_set_hwaddr(struct eth_device *dev) @@ -414,9 +410,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd) uint32_t base; struct fec_priv *fec = (struct fec_priv *)dev->priv;
- /* Initialize MAC address */
- fec_set_hwaddr(dev);
Not sure. Why is this call removed ? We have changed the storage for the MAC address, but we need always to set the FEC controller. What is the reason to drop it ?
It's because, it will print some floating value of MAC address when bootup and in fact, we don't need re-set it again here.. The net framework will do that. This is why I remove. it.
Best regards, Stefano Babic
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot