Re: [PATCH 5/5] ds414: Add sample u-boot update command

On 03.03.21 01:55, Phil Sutter wrote:

Signed-off-by: Phil Sutter phil@nwl.cc

It's common practice to add some minimal text in the commit text, even for simple patches.

One short question below...

---

include/configs/ds414.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/configs/ds414.h b/include/configs/ds414.h index a2248cf75ad72..c8b45066cc75a 100644 --- a/include/configs/ds414.h +++ b/include/configs/ds414.h @@ -88,7 +88,12 @@ "initrd_high=0xffffffff\0" \ "ramdisk_addr_r=0x8000000\0" \ "usb0Mode=host\0usb1Mode=host\0usb2Mode=device\0" \

• "ethmtu=1500\0eth1mtu=1500\0"

• "ethmtu=1500\0eth1mtu=1500\0" \
• "update_uboot=sf probe; dhcp; " \

• "mw.b ${loadaddr} 0x0 0xd0000; "		\
  

• "tftpboot ${loadaddr} u-boot-spl.kwb; "		\
  

• "sf update ${loadaddr} 0x0 0xd0000\0"
  

Wouldn't it be better to use ${filesize} instead of 0xd0000 here?

Other than that:

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan