Ben and Wolfgang,
thank you for the hints.
One problem with following the coding standards is that if I apply the linux Lindent script, the entire file (drivers/bcm570x.c) gets changed - it does not follow the u-boot/Linux coding standards in the first place (I suspect other files being changed with my submission are like that too). I can make sure that the lines I changed are compliant but this would make the file(s) look ugly with a mix of styles, or I can run the entire file through Lindent, but then the diffs would be polluted.
What's the best way to proceed here?
Cheers, /v
On 5/24/07, Ben Warren bwarren@qstreams.com wrote:
Hi Vadim,
--- Vadim Bendebury vbendeb@yahoo.com wrote:
Wolfgang,
thank you for a quick reply. Sorry for not following the coding conventions, I'll address this concern, I am more worried why there are so many patch failures. What's the revision of the file you're applying the patch against and what is the exact patch command you're using?
cheers, /vb
Here are the expectations:
- Patch will apply against the current git head
- The command used by custodians is
git am --signoff --whitespace=strip < PATCH_FILE
Notice that this strips offending whitespace. You should take care to not have any in the first place, though.
I suggest that before sending a patch, you clone the head and try this command. That way you can hopefully avoid *some* scorn from Wolfgang. Speaking of which... I'll try to preempt him and warn you about top-quoting. It's considered bad form.
Thanks for working on this and we look forward to your patches.
cheers, Ben