Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

Hi Mike,

2011/4/15 Mike Frysinger vapier@gentoo.org:

On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:

...

#if !defined(CONFIG_ENV_IS_IN_EEPROM)        && \

• !defined(CONFIG_ENV_IS_IN_FLASH) && \

• !defined(CONFIG_ENV_IS_IN_FLASH)        && \

not sure this one hunk is desirable, but the rest are fine -mike

Do you mean the replacement with space to ident?

According to the 2.6.38.1's checkpatch, it reported: WARNING: please, no spaces at the start of a line #90: FILE: common/cmd_bdinfo.c:61: + defined(CONFIG_8260) || defined(CONFIG_E500)$

We have got lots of such warnings.

I think we can use little pieces of times to do the cleanup work. If Wolfgang has no comment to such coding style clean up, I'll do it slowly when I have time.

Thanks.