Re: [U-Boot] [PATCH RESEND] Added support for splash screen positioning

Dear Matthias Weisser,

In message 1246460471-12737-1-git-send-email-matthias.weisser@graf-syteco.de you wrote:

This patch adds support splash image positioning by optinally adding x and y coordinates to the splashimage environment variable.

Signed-off-by: Matthias Weisser matthias.weisser@graf-syteco.de

README | 8 ++++++-- common/lcd.c | 11 +++++++++-- drivers/video/cfb_console.c | 9 ++++++++- 3 files changed, 23 insertions(+), 5 deletions(-) mode change 100644 => 100755 README mode change 100644 => 100755 common/lcd.c mode change 100644 => 100755 drivers/video/cfb_console.c

diff --git a/README b/README old mode 100644 new mode 100755 index 561c100..dd47a83 --- a/README +++ b/README @@ -1069,8 +1069,12 @@ The following options need to be configured: a variable "splashimage". If found, the usual display of logo, copyright and system information on the LCD is suppressed and the BMP image at the address

• specified in "splashimage" is loaded instead. The
  

• console is redirected to the "nulldev", too. This
  

• specified in "splashimage" is loaded instead.
  

• The logo can be positioned on any position by
  

• (optionally) adding the x and y coordinates after the
  

• address in the environment variable "splashimage"
  

• sperated by a space. "splashimage=0x10060000 160 120"
  

• The console is redirected to the "nulldev", too. This
  

  allows for a "silent" boot where a splash screen is loaded very quickly after power-on.

This is a bogus user interface. I will not accept this. Please redesign (probably use separate variable(s) for the coordinates).

NAK.

Best regards,

Wolfgang Denk