Hi,
On 14 April 2014 09:15, Przemyslaw Marczak p.marczak@samsung.com wrote:
Hello, I like this idea. This is a good feature for easy and fast gpio maintaining. I have few comments to this.
On 04/12/2014 11:43 AM, Akshay Saraswat wrote:
From: Rajeshwari Shinde rajeshwari.s@samsung.com
This patch adds gpio pin numbering support for EXYNOS 5250 & 5420. To have consistent 0..n-1 GPIO numbering the banks are divided into different parts where ever they have holes in them.
Signed-off-by: Leela Krishna Amudala l.krishna@samsung.com Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com Signed-off-by: Akshay Saraswat akshay.s@samsung.com
You use quite magic numbers in gpio names like "EXYNOS5_GPIO_A05", maybe better is to add "PIN" word here like this: EXYNOS5_GPIO_A0_PIN5. So then we really know what we are using and I think this just looks better.
I'm not sure I agree with the idea of a more verbose naming. The naming in this series fits better with the idea of numbered GPIOs. The bank number is of limited interest to users of GPIOs anyway. Exynos is slightly odd in that banks have both a letter and number (A0, A1), but that doesn't seem like a reason to change.
Regards, Simon