On Friday 20 July 2012 00:44:52 Mike Frysinger wrote:
On Thursday 19 July 2012 18:03:06 Benoît Thébaudeau wrote:
--- u-boot-66714b1.orig/fs/fat/fat.c +++ u-boot-66714b1/fs/fat/fat.c
+__u8 get_contents_vfatname_block[MAX_CLUSTSIZE]
- __aligned(ARCH_DMA_MINALIGN);
is there any reason for this to be exported ? could you mark it static ?
I'll do that. There are probably other variables in fat.c missing static, so I'll do a dedicated patch before this series. That will shift the patch numbers. How should I repost the new version of the series? Should I keep the message ID of each patch even if the numbering changes, or should I post a v2 completely separately from v1?
static long -get_contents (fsdata *mydata, dir_entry *dentptr, __u8 *buffer,
unsigned long maxsize)+get_contents (fsdata *mydata, dir_entry *dentptr, unsigned long pos,
delete the space before the "("
long -do_fat_read (const char *filename, void *buffer, unsigned long maxsize,
int dols)+do_fat_read_at (const char *filename, unsigned long pos, void *buffer,
delete the space before the "("
+long +do_fat_read (const char *filename, void *buffer, unsigned long maxsize,
no spaces before that "("
I'll add a cosmetic patch for that in a prequel.
Regards, Benoît