On Sun, 27 Nov 2022 10:25:01 -0500 Tom Rini trini@konsulko.com wrote:
Hi Tom,
This value is always defined to 0, so move it to Kconfig as being set to always 0.
Yeah, but that's not needed in Kconfig at all, it's just a name for the first MMC slot, its definition being misplaced in the config directory. I will send a patch that removes the CONFIG_ prefix and moves it into the C file using it, so you can drop this patch here.
Thanks, Andre
Cc: Andre Przywara andre.przywara@arm.com C: Icenowy Zheng icenowy@aosc.io Signed-off-by: Tom Rini trini@konsulko.com
arch/arm/mach-sunxi/Kconfig | 4 ++++ include/configs/sunxi-common.h | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index dbe6005daab1..c311a6d03523 100644 --- a/arch/arm/mach-sunxi/Kconfig +++ b/arch/arm/mach-sunxi/Kconfig @@ -685,6 +685,10 @@ config MMC1_PINS_PH ---help--- Select this option for boards where mmc1 uses the Port H pinmux.
+config MMC_SUNXI_SLOT
- int
- default 0
config MMC_SUNXI_SLOT_EXTRA int "mmc extra slot number" default -1 diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 1677aafad03b..496139f34635 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -69,9 +69,6 @@ #define PHYS_SDRAM_0 CFG_SYS_SDRAM_BASE #define PHYS_SDRAM_0_SIZE 0x80000000 /* 2 GiB */
-/* mmc config */ -#define CONFIG_MMC_SUNXI_SLOT 0
/*
- Miscellaneous configurable options
*/