Hello
2015-07-22 13:53 GMT+02:00 Boris Brezillon boris.brezillon@free-electrons.com:
I'd suggest removing the comment and making the following options configurable, with the default values as provided, in Kconfig: CONFIG_NAND_PAGE_SIZE 0x2000 CONFIG_NAND_ECC_PAGE_SIZE 0x400 CONFIG_NAND_SUNXI_ECC_STRENGTH 40 CONFIG_NAND_SYNDROME_PARTITIONS_END 0x400000
Do you think that would be sensible?
Yep, that pretty much what I was expecting. Just put those definition into a board config header, or add a Kconfig entry.
Ok, will be done.
In general you may find that constants regarding NANDs are kept in .h files around U-Boot, so I'd like stick with that convention.
This is true for all generic definitions, not for driver specific ones.
Well, that's not true for all the drivers, as we have tegra_nand.h and atmel_nand_ecc.h, never used elsewhere apart from their corresponding *.c files.
Especially if we'd have two drivers, one header will be needed.
But if that would ease your work, I'll merge sunxi_nand.h to sunxi_nand.c and rename it as you suggest.
Best regards
Piotr Zierhoffer Antmicro Ltd | www.antmicro.com