
-----Original Message----- From: Stefano Babic [mailto:sbabic@denx.de] Sent: 2018年10月25日 16:26 To: Peng Fan peng.fan@nxp.com; Anatolij Gustschin agust@denx.de Cc: sbabic@denx.de; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists
Hi Peng,
On 25/10/18 03:14, Peng Fan wrote:
-----Original Message----- From: Anatolij Gustschin [mailto:agust@denx.de] Sent: 2018年10月25日 7:44 To: Peng Fan peng.fan@nxp.com Cc: sbabic@denx.de; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] imx: mkimage: avoid stop CI when required files not exists
Hi Peng,
On Wed, 24 Oct 2018 09:49:04 +0000 Peng Fan peng.fan@nxp.com wrote: ...
--- /dev/null +++ b/tools/imx8_cntr_image.sh @@ -0,0 +1,32 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0+ # # script to generate FIT +image source for K3 Family boards with # ATF, OPTEE, SPL and +multiple device trees (given on the command line). +# Inspired from board/sunxi/mksunxi_fit_atf.sh
Please drop this comment, it doesn't describe what the script is actually
doing.
Thanks. Fix in V2.
I wanted to send my PR as soon as possible to Tom. I didn't want to block i.MX8 merge just for this, and I merged V1 and sent PR.
No, please not use v1.
V2 patch will be out soon. It is under CI test. I'll send out now.
Thanks, Peng.
Can you send then a follow-up patch instead of V2 ? V1 is on u-boot-imx, and Tom will merge the tree soon.
Best regards, Stefano
...
+file=$1
+linecount=`cat ${file} | wc -l`
+for ((i=1; i<=${linecount}; i++)); +do
[ snip ]
blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ || /^DATA/ {print $3}' $file` for f in $blobs; do if [ ! -f $f ]; then echo "WARNING '$f' not found, resulting binary is not-functional" fi; done
will do the checks more efficiently.
Yes. Simpiler.
Thanks, Peng.
Thanks,
Anatolij
--
===== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de ================================================================ =====