Dear Stefano Babic,
On 31/08/2012 01:39, Marek Vasut wrote:
This is based on Linux kernel -next:
commit a1256b0e087ed3cdb584c683acb966ee885f733c Author: Brian Norris computersforpeace@gmail.com Date: Fri Jul 13 09:28:24 2012 -0700
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver The NAND_CHIPOPTIONS_MSK has limited utility and is causing real bugs. It silently masks off at least one flag that might be set by the driver (NAND_NO_SUBPAGE_WRITE). This breaks the GPMI NAND driver and possibly others. Really, as long as driver writers exercise a small amount of care with NAND_* options, this mask is not necessary at all; it was only here to prevent certain options from accidentally being set by the driver. But the original thought turns out to be a bad idea occasionally. Thus, kill it. Note, this patch fixes some major gpmi-nand breakage.Signed-off-by: Marek Vasut marex@denx.de Cc: Brian Norris computersforpeace@gmail.com Cc: Eric Nelson eric.nelson@boundarydevices.com Cc: Fabio Estevam festevam@gmail.com Cc: Otavio Salvador otavio@ossystems.com.br Cc: Scott Wood scottwood@freescale.com
Hi Marek,
drivers/mtd/nand/nand_base.c | 7 ++----- include/linux/mtd/nand.h | 3 --- 2 files changed, 2 insertions(+), 8 deletions(-)
NOTE: Please test before applying, I'd like to know it doesn't cause breakage.
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index bfd668f..658b3ad 100644
This fixes the same issue on the ea20 (davinci), and drop the painful NAND_CHIPOPTIONS_MSK. Thanks !
I'm glad. I hope I didn't infringe anything with this patch and that I properly followed this "porting Linux patches" procedure.
Regards, Stefano
Best regards, Marek Vasut