Dear Timur Tabi,
In message 4D7F83EC.4050804@freescale.com you wrote:
NAK. video-mode settings and console settings are two separate things and must not be mangled into a single variable.
Well, that's why I have two variables. My patch has the ability to set the kernel command line appropriately if the video display is configured and enabled in U-Boot. The second variable is used to assist in setting the actual kernel command-line, because that's the easiest and safest way to do it. An
Don't try to be more clever than the user. Instead of helping, you restrict him. That's bad.
alternative that I tried to implement is to have do_bootm_linux() edit the kernel command line directly, removing any existing video= option and putting a
NAK, NAK, NAK. All such automatic and unconditional editing is bad and should strictly be avoided.
Leave the decision which device to use as console to the user.
There are three things that need to be done:
- The video mode needs to be configured
ACK.
- The video display needs to be enabled and the U-Boot console needs to be
routed to it
NAK.
Wether the U-Boot console is attached to the serial port or the video console or netconsole or anything else should be left to the user.
A default setting is OK, but the user must be able to set anything he likes.
- The kernel command line needs to be set
ACK. Again, the user must have free choice of options.
For #1, we use video-mode. How do you want #2 and #3 handled?
See above.
Best regards,
Wolfgang Denk