
Hi Wolfgang,
Am Do., 4. Nov. 2021 um 20:12 Uhr schrieb Wolfgang Denk wd@denx.de:
Dear Heiko,
In message 20211104185231.2927-1-heiko.thiery@gmail.com you wrote:
While converting to binman for an imx8mq board, it has been found that building in the u-boot CI fails. This is because an imx8mq requires an external binary (signed_hdmi_imx8m.bin). If this file cannot be found mkimage fails. To work around the problem the exception is caught, an error message is printed and binman continues.
But how can you continue, when mkimage fails and cannot generate the needed image?
In your patch 2/2 we have this:
tools.Run('mkimage', '-d', input_fname, *self._args, output_fname)
except Exception as e:
tout.Error("mkimage failed: %s" % e)
self.SetContents(tools.ReadFile(output_fname))
mkimage is supposed to create an output file which name is in output_fname; if mkimage fails and you continue, the next step is tools.ReadFile(output_fname) trying to read that file. How is this possible?
# ls -al mkimage* -rw-r--r-- 1 hthiery hthiery 0 Nov 4 20:28 mkimage-out.spl.mkimage -rw-r--r-- 1 hthiery hthiery 180392 Nov 4 20:28 mkimage.spl.mkimage
The file (mkimage-out.spl.mkimage) with size 0 seems to be created. I assume mkimage will create that.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "One day," said a dull voice from down below, "I'm going to be back in form again and you're going to be very sorry you said that. For a very long time. I might even go so far as to make even more Time just for you to be sorry in." - Terry Pratchett, _Small Gods_