Re: [U-Boot] [RESEND PATCH 5/5] clk: add enable() callback

Hi Simon,

2015-12-28 23:20 GMT+09:00 Simon Glass sjg@chromium.org:

Hi Masahiro,

On 22 December 2015 at 03:04, Masahiro Yamada yamada.masahiro@socionext.com wrote:

...

The most basic thing for clock is to enable it, but it is missing in this uclass.

Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com

include/clk.h | 9 +++++++++ 1 file changed, 9 insertions(+)

Acked-by: Simon Glass sjg@chromium.org

Thinking ahead, should we have disable() also, or maybe replacing both with set_enable(bool enable) would be better?

Yes, we'd better to implement disable() just in case.

We mostly just enable clocks, and never disable them in a boot loader, though.