Re: [PATCH v6 01/20] dm: core: Fix uclass_probe_all to really probe all devices

On Wed, 12 Oct 2022 at 13:58, Michal Suchanek msuchanek@suse.de wrote:

uclass_probe_all uses uclass_first_device/uclass_next_device assigning the return value.

The interface for getting meaningful error is uclass_first_device_check/uclass_next_device_check, use it.

Also do not stop iteration when an error is encountered. Probing all devices includes those that happen to be after a failing device in the uclass order.

Fixes: a59153dfeb ("dm: core: add function uclass_probe_all() to probe all devices") Signed-off-by: Michal Suchanek msuchanek@suse.de

---

v6: add test

drivers/core/uclass.c | 12 +++++------- test/dm/test-fdt.c | 19 +++++++++++++++---- 2 files changed, 20 insertions(+), 11 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org