On Mon, Sep 6, 2010 at 4:28 PM, Wolfgang Denk wd@denx.de wrote:
Dear Lei Wen,
In message 1283757567-15161-1-git-send-email-leiwen@marvell.com you wrote:
As mmc host limitation, the max number of block in one go should be limited to 65535, and the max buffer size should not excceed 512k bytes.
There is a typo in the Subject ("separate"), and actually I think the Subject is a bit misleading. How about "limit block count for multi-block write commands" or so?
I agree with that. :-)
- data.blocks = blkcnt;
- data.blocks = blocknum;
Be careful with your variable names. Most people will read "blocknum" as "block number" (and interpret it as an index, i. e. as the logical block address on the device), while you probably mean "number of block" - the old name "blkcnt" was more appropriate.
Why is mmc_write_block() not static?
For mmc.c provide a mmc read api as: int mmc_read_block(struct mmc *mmc, void *dst, uint blocknum)
So I think it is reasonable to also provide a write api like that, should it be like?... Variable blocknum is allow following mmc_read_block style.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de SW engineering is a race between programmers trying to make better idiot-proof programs and the universe producing greater idiots. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot