Dear Wolfgang,
Wolfgang Denk wrote:
Dear Mike Rapoport,
In message 1257955131-16729-1-git-send-email-mike@compulab.co.il you wrote:
Add CM-T35 board support
-- v2 changes:
- rename board config file from omap3_cm-t35.h to cm-t35.h
- remove SZ_xx references
- add MAKEALL/MAINTEINERS entries
--
Signed-off-by: Mike Rapoport mike@compulab.co.il
The Signed-off-by: line belongs _above_ the "--" line.
--- a/MAINTAINERS +++ b/MAINTAINERS @@ -677,6 +677,10 @@ Stelian Pop stelian.pop@leadtechdesign.com at91sam9263ek ARM926EJS (AT91SAM9263 SoC) at91sam9rlek ARM926EJS (AT91SAM9RL SoC)
+Mike Rapoport mike@compulab.co.il
- omap3_cm-t35 ARM CORTEX-A8 (OMAP3xx SoC)
Please fix the board name.
diff --git a/board/cm-t35/cm-t35.c b/board/cm-t35/cm-t35.c new file mode 100644 index 0000000..b3eb087 --- /dev/null +++ b/board/cm-t35/cm-t35.c
- udelay(1);
- twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0x02,
TWL4030_BASEADD_GPIO+0x0C);+}
Delete this empty line, please (please check globally).
+++ b/board/cm-t35/cm-t35.h
...
+#define MUX_CM_T35() \
- /*SDRC*/\
- MUX_VAL(CP(SDRC_D0), (IEN | PTD | DIS | M0)) /*SDRC_D0*/\
... Indentation by TAB, please.
+++ b/board/cm-t35/config.mk @@ -0,0 +1,30 @@
...
+# For use with external or internal boots. +TEXT_BASE = 0x80e80000 \ No newline at end of file
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please fix.
diff --git a/include/configs/cm-t35.h b/include/configs/cm-t35.h new file mode 100755 index 0000000..b881112 --- /dev/null +++ b/include/configs/cm-t35.h
...
+#ifndef __ASSEMBLY__ +extern struct gpmc *gpmc_cfg; +extern unsigned int boot_flash_base; +extern volatile unsigned int boot_flash_env_addr; +extern unsigned int boot_flash_off; +extern unsigned int boot_flash_sec; +extern unsigned int boot_flash_type; +#endif
These should not be needed in your board config file. Please move to a more appropriate header.
This is what all other omap3 board do... Moving these requires some rework of common omap3 code and updates to all omap3 boards.
Best regards,
Wolfgang Denk