On Tue, May 14, 2019 at 12:55 PM Simon Glass sjg@chromium.org wrote:
Hi Julius,
On Mon, 13 May 2019 at 19:13, Julius Werner jwerner@chromium.org wrote:
Is there a change log for this patch?I think we discussed having a test.
Sorry, forgot that. Is it okay if I just put it here or do you need me to resend a v4?
I think it should be a v4 so it looks right in patchwork.
Also for this patch, can you please add documentation - see source_file_format.txt
I had submitted a patch for that file already last year but then got stuck in implementing just this, see commit fd15a9e2565f here: https://github.com/u-boot/u-boot/commit/fd15a9e2565f831bf95c2152d1966d068a64...
I don't know if this compression support needs anything more specific in that doc file. If anything, we could explicitly state that compression is now supported for all nodes, but then again, the file didn't tell that it was only supported for Kernels...
Regards, Simon
Changes for v2:
- made decompression work for all non-kernel images, not just FDTs
Changes for v3:
- fixed up debug output that was still written for v1
- fixed a mistake with handling FIT_LOAD_OPTIONAL_NON_ZERO when
'load' was 0 (i.e. unset)
- added compression test case to test_fit
- Simon