Re: [U-Boot] [PATCH v6 01/17] arm: ls102xa: Add Freescale LS102xA SoC support

Dear Alison Wang,

In message 1409895853-17736-2-git-send-email-alison.wang@freescale.com you wrote:

• unsigned long sysclk = CONFIG_SYS_CLK_FREQ;
• sys_info->freq_systembus = sysclk;

+#ifdef CONFIG_DDR_CLK_FREQ

• sys_info->freq_ddrbus = CONFIG_DDR_CLK_FREQ;

+#else

• sys_info->freq_ddrbus = sysclk;

+#endif

I think this should be simplified into a

#ifndef CONFIG_DDR_CLK_FREQ #define CONFIG_DDR_CLK_FREQ CONFIG_SYS_CLK_FREQ #endif

somewhere in a header file, and getting rid of the #ifdef here?

Best regards,

Wolfgang Denk