Re: [U-Boot] [PATCH v3 4/8] power: pmic: rk805: support rk805 pmic

On 2019/9/19 下午4:08, Elaine Zhang wrote:

The RK805 are a Power Management IC (PMIC) for multimedia and handheld devices. They contains the following components: - Regulators(4*BUCKs, 3*LDOs) - RTC - Clocking

Signed-off-by: Elaine Zhang zhangqing@rock-chips.com

Reviewed-by: Kever Yangkever.yang@rock-chips.com

Thanks, - Kever

---

drivers/power/pmic/rk8xx.c | 1 + drivers/power/regulator/rk8xx.c | 17 +++++++++++++++++ include/power/rk8xx_pmic.h | 1 + 3 files changed, 19 insertions(+)

diff --git a/drivers/power/pmic/rk8xx.c b/drivers/power/pmic/rk8xx.c index 1900de9d1cdb..00c8a2e091d8 100644 --- a/drivers/power/pmic/rk8xx.c +++ b/drivers/power/pmic/rk8xx.c @@ -94,6 +94,7 @@ static struct dm_pmic_ops rk8xx_ops = { };

static const struct udevice_id rk8xx_ids[] = {

• { .compatible = "rockchip,rk805" }, { .compatible = "rockchip,rk808" }, { .compatible = "rockchip,rk816" }, { .compatible = "rockchip,rk818" },

diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c index 3188d3c6350d..e9d83635988b 100644 --- a/drivers/power/regulator/rk8xx.c +++ b/drivers/power/regulator/rk8xx.c @@ -38,7 +38,14 @@ /*

• Ramp delay

*/ +#define RK805_RAMP_RATE_OFFSET 3 +#define RK805_RAMP_RATE_MASK (3 << RK805_RAMP_RATE_OFFSET) +#define RK805_RAMP_RATE_3MV_PER_US (0 << RK805_RAMP_RATE_OFFSET) +#define RK805_RAMP_RATE_6MV_PER_US (1 << RK805_RAMP_RATE_OFFSET) +#define RK805_RAMP_RATE_12_5MV_PER_US (2 << RK805_RAMP_RATE_OFFSET) +#define RK805_RAMP_RATE_25MV_PER_US (3 << RK805_RAMP_RATE_OFFSET) #define RK808_RAMP_RATE_OFFSET 3

• #define RK808_RAMP_RATE_MASK (3 << RK808_RAMP_RATE_OFFSET) #define RK808_RAMP_RATE_2MV_PER_US (0 << RK808_RAMP_RATE_OFFSET) #define RK808_RAMP_RATE_4MV_PER_US (1 << RK808_RAMP_RATE_OFFSET)

@@ -131,6 +138,7 @@ static const struct rk8xx_reg_info *get_buck_reg(struct udevice *pmic, struct rk8xx_priv *priv = dev_get_priv(pmic);

switch (priv->variant) {

• case RK805_ID: case RK816_ID: switch (num) { case 0:

@@ -185,6 +193,7 @@ static int _buck_set_enable(struct udevice *pmic, int buck, bool enable) struct rk8xx_priv *priv = dev_get_priv(pmic);

switch (priv->variant) {

• case RK805_ID: case RK816_ID: if (buck >= 4) { buck -= 4;

@@ -246,6 +255,7 @@ static int _buck_get_enable(struct udevice *pmic, int buck) int ret = 0;

switch (priv->variant) {

• case RK805_ID: case RK816_ID: if (buck >= 4) { mask = 1 << (buck - 4);

@@ -277,6 +287,7 @@ static int _buck_set_suspend_enable(struct udevice *pmic, int buck, bool enable) struct rk8xx_priv *priv = dev_get_priv(pmic);

switch (priv->variant) {

• case RK805_ID: case RK816_ID: mask = 1 << buck; ret = pmic_clrsetbits(pmic, RK816_REG_DCDC_SLP_EN, mask,

@@ -302,6 +313,7 @@ static int _buck_get_suspend_enable(struct udevice *pmic, int buck) uint mask;

switch (priv->variant) {

• case RK805_ID: case RK816_ID: mask = 1 << buck; val = pmic_reg_read(pmic, RK816_REG_DCDC_SLP_EN);

@@ -330,6 +342,7 @@ static const struct rk8xx_reg_info *get_ldo_reg(struct udevice *pmic, struct rk8xx_priv *priv = dev_get_priv(pmic);

switch (priv->variant) {

• case RK805_ID: case RK816_ID: return &rk816_ldo[num]; case RK818_ID:

@@ -346,6 +359,7 @@ static int _ldo_get_enable(struct udevice *pmic, int ldo) int ret = 0;

switch (priv->variant) {

• case RK805_ID: case RK816_ID: if (ldo >= 4) { mask = 1 << (ldo - 4);

@@ -378,6 +392,7 @@ static int _ldo_set_enable(struct udevice *pmic, int ldo, bool enable) int ret = 0;

switch (priv->variant) {

• case RK805_ID: case RK816_ID: if (ldo >= 4) { ldo -= 4;

@@ -410,6 +425,7 @@ static int _ldo_set_suspend_enable(struct udevice *pmic, int ldo, bool enable) int ret = 0;

switch (priv->variant) {

• case RK805_ID: case RK816_ID: mask = 1 << ldo; ret = pmic_clrsetbits(pmic, RK816_REG_LDO_SLP_EN, mask,

@@ -433,6 +449,7 @@ static int _ldo_get_suspend_enable(struct udevice *pmic, int ldo) uint mask;

switch (priv->variant) {

• case RK805_ID: case RK816_ID: mask = 1 << ldo; val = pmic_reg_read(pmic, RK816_REG_LDO_SLP_EN);

diff --git a/include/power/rk8xx_pmic.h b/include/power/rk8xx_pmic.h index 44e8d687dfba..7784c2a5e473 100644 --- a/include/power/rk8xx_pmic.h +++ b/include/power/rk8xx_pmic.h @@ -179,6 +179,7 @@ enum { };

enum {

• RK805_ID = 0x8050, RK808_ID = 0x0000, RK816_ID = 0x8160, RK818_ID = 0x8180,