On Thu, Mar 14, 2013 at 12:35:46PM +0000, Adnan Ali wrote:
Introduces btrfs file-system to read file from volume/sub-volumes with btrload command. This implementation has read-only support. This btrfs implementation is based on syslinux btrfs code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
OK, sorry for not doing this part sooner, but I compared the btrfs code in syslinux to your code and there's a lot of whitespace problems in fs/btrfs/btrfs.c that you: trini@bill-the-cat:~/work/u-boot/u-boot$ ./tools/checkpatch.pl -f fs/btrfs/btrfs.c | grep ^ERROR | wc -l 320 trini@bill-the-cat:~/work/u-boot/u-boot$ ./tools/checkpatch.pl -f ~/work/syslinux/core/fs/btrfs/btrfs.c | grep ^ERR | wc -l 7
Please fix this, use whitespace consistent with the rest of the file for the U-Boot specific functions you're adding and as Simon noted, 'char' for a return type on btrfs_ls isn't really right (please follow fat or ext* for examples).
Thanks and again, sorry for not noticing this sooner in the reviews.