Dear Rupjyoti Sarmah,
In message 201007070632.o676WvS8029128@amcc.com you wrote:
Functions added to support board callbacks for USB init. This isolates USB manipulations such that it is only touched if USB is used by U-Boot.
Signed-off-by: Dave Mitchell dmitchell@appliedmicro.com Signed-off-by: Rupjyoti Sarmah rsarmah@appliedmicro.com
This patch incorporates the changes advised.
if (pvr_460ex()) { printf("Board: Canyonlands - AMCC PPC460EX Evaluation Board");
if (in_8((void *)(CONFIG_SYS_BCSR_BASE + 3)) & CONFIG_SYS_BCSR3_PCIE)
if (bcsr_data->board_status & CONFIG_SYS_BCSR3_PCIE)
Please use I/O accessors to read the BCSR.
- printf(", Rev. %X", in_8((void *)(CONFIG_SYS_BCSR_BASE + 0)));
- printf(", Rev. %X", bcsr_data->cpld_rev);
Ditto. There are more changes like this - please fix all of them.
--- a/include/configs/canyonlands.h +++ b/include/configs/canyonlands.h @@ -77,6 +77,18 @@ #define CONFIG_SYS_PCIE0_XCFGBASE 0xc3000000 #define CONFIG_SYS_PCIE1_XCFGBASE 0xc3001000
+/*
- BCSR bits as defined in the ep460c board user manual
- */
What is "ep460c"? We know 460EX (the CPU) and Canyonlands (the board).
Best regards,
Wolfgang Denk