Hi,
On 30-06-15 22:46, Tom Rini wrote:
On Tue, Jun 30, 2015 at 10:33:17PM +0200, Hans de Goede wrote:
Select a bunch of CONFIG_foo options from ARCH_SUNXI, instead of having them set to y in every single sunxi defconfig.
Signed-off-by: Hans de Goede hdegoede@redhat.com
Ug, sorry, I was waiting for some build results to come out before posting my version of this.
No problem.
To update the USB side: $ for F in `git grep -l SYS_EXTRA.*USB_EHCI`;do sed -i -e 's/,USB_EHCI//' -e 's/USB_EHCI,//' $F && echo CONFIG_USB_EHCI_HCD=y >> $F;done
And was there a reason you didn't include a 'select DM_SERIAL' in yours?
Yes setting that for all boards breaks booting of boards which do not have a serial port as drivers/serial/serial-uclass.c: serial_find_console_or_panic() will then panic (runtime error, yeah).
And we've one such board. I've a fix for this, next step is to merge your and mine patches as both have some good things the other one does not have (I like your work on setting CONFIG_USB_EHCI_HCD, but you're not selecting CONFIG_USB).
I've run out of steam for today, so I will try to get this done tomorrow.
[snip]
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 0829235..6c4d138 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -645,10 +645,13 @@ config ARCH_SOCFPGA config ARCH_SUNXI bool "Support sunxi (Allwinner) SoCs" select DM
- select DM_ETH select DM_GPIO
- select DM_USB if !USB_MUSB_SUNXI select OF_CONTROL select OF_SEPARATE select SPL_DISABLE_OF_CONTROL
- select USB
We really don't want to leave USB as a board choice?
All sunxi SoCs have 2 - 4 (*) usb controllers, and there does not exist a single board which does not at least uses one usb controller, and I like to keep things consistent where ever possible to reduce the combinatorial explosion problem all these Kconfig options give us.
Regards,
Hans
*) 3 - 6 if you count ehci/ohci seperately.