
12 Feb
2008
12 Feb
'08
7:02 a.m.
In message 200802120612.46861.sr@denx.de you wrote:
This is set to 512 for small page devices and set to 2k for large page devices. So the code can be "selected" via this #if statement:
#if (CFG_NAND_PAGE_SIZE > 512)
Please use an explicit test instead, i. e. for example
#if (CFG_NAND_PAGE_SIZE == 2048)
unless you are absolutley sure that all future devices (say, with 8k or 8k page sizes) will behave identical. Otherwise it will be a mess to clean up that code later.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Ordnung ist die Lust der Vernunft,
aber Unordnung die Wonne der Phantasie - Paul Claudel