Hello Christian,
On 12.08.24 12:32, Christian Marangi wrote:
Implement support for LED activity. If the feature is enabled, make the defined ACTIVITY LED to signal ubi write operation.
Signed-off-by: Christian Marangi ansuelsmth@gmail.com
cmd/ubi.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/cmd/ubi.c b/cmd/ubi.c index 0e62e449327..6f679eae9c3 100644 --- a/cmd/ubi.c +++ b/cmd/ubi.c @@ -14,6 +14,7 @@ #include <command.h> #include <env.h> #include <exports.h> +#include <led.h> #include <malloc.h> #include <memalign.h> #include <mtd.h> @@ -488,10 +489,22 @@ exit:
int ubi_volume_write(char *volume, void *buf, loff_t offset, size_t size) {
- int ret;
+#ifdef CONFIG_LED_ACTIVITY_ENABLE
- led_activity_blink();
+#endif
Do we really need ifdef? May it is possible to declare an empty function when CONFIG_LED_ACTIVITY_ENABLE is not set? May this applies for the whole series?
- if (!offset)
return ubi_volume_begin_write(volume, buf, size, size);
ret = ubi_volume_begin_write(volume, buf, size, size);- else
ret = ubi_volume_offset_write(volume, buf, offset, size);
- return ubi_volume_offset_write(volume, buf, offset, size);
+#ifdef CONFIG_LED_ACTIVITY_ENABLE
- led_activity_off();
+#endif
return ret; }
int ubi_volume_read(char *volume, char *buf, loff_t offset, size_t size)
bye, Heiko