On 05/01/2013 05:03 PM, Tom Rini wrote:
On Wed, May 01, 2013 at 10:59:20AM +0200, Michal Simek wrote:
In bitstream decoding you can directly check device which you want to load and in fpga.c are fpga_validate and fpga_dev_info functions which should be used for it.
Signed-off-by: Michal Simek michal.simek@xilinx.com
[snip]
+++ b/drivers/fpga/fpga.c
[snip]
+#else
- printf("Bitstream support only for Xilinx devices\n");
- return FPGA_FAIL;
+#endif
How about we re-work this as a __weak fpga_loadbitstream in drivers/fpga/fpga.c that just says "Bitstream support not implemented for this FPGA device", return FPGA_FAIL, and move the xilinx one into drivers/fpga/xilinx.c ?
yep. Make sense to do it because at least from this code altera or lattice don't support bitstream loading. It will be more problematic if there is a board on the market with different fpgas.
I even not sure if other fpga vendors have bitstream with any header which should be used by this command.
Thanks, Michal