Re: [U-Boot] [PATCH v3] sf: Macronix additional chips supported

On Monday 06 July 2009 07:41:52 Prafulla Wadaskar wrote:

• u16 id = (u16 *) *idcode;

sorry, this wont fly on systems that cannot do unaligned accesses. i dont know the status of the get_unaligned() type macros in u-boot, but it'll probably be easier to just do: idcode[0] | idcode[1] << 8;

• if (params->idcode1 == idcode[2])
  

•            if (params->idcode == id)
  

• debug("SF: Unsupported Macronix ID %02x\n", idcode[1]);
  

•            debug("SF: Unsupported Macronix ID %04x\n", id);
  

you've still got busted whitespace here :/ -mike