10 Dec
2015
10 Dec
'15
1:52 a.m.
On Thu, Dec 10, 2015 at 3:21 AM, Stefan Agner stefan@agner.ch wrote:
When doing a software reset, the reset flag should be written without other bits set. Writing the current state will lead to restoring the state of the PHY (e.g. Powerdown), which is not what is expected from a software reset.
Signed-off-by: Stefan Agner stefan@agner.ch
This lead to the PHY staying powered down on a reboot when using a Micrel PHY and not using hardware reset...
It also aligns with the behavior of Linux: http://lxr.free-electrons.com/source/drivers/net/phy/phy_device.c#L1122
-- Stefan
drivers/net/phy/phy.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com