Re: [U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM functions

On Wed, Aug 12, 2015 at 02:07:20PM -0500, Joe Hershberger wrote:

On Wed, Aug 12, 2015 at 12:24 PM, Andrew Ruder andrew.ruder@elecsyscorp.com wrote:

...

/****************** function prototypes **********************/ #if !defined(CONFIG_DM9000_NO_SROM) -void dm9000_write_srom_word(int offset, u16 val); -void dm9000_read_srom_word(int offset, u8 *to); +struct eth_device;

+void dm9000_write_srom_word(struct eth_device *dev, int offset, u16 val); +void dm9000_read_srom_word(struct eth_device *dev, int offset, u8 *to);

It will be better to pass the dm9000_priv* instead. See patch 5 for details.

Even on the "public"-facing functions?

Thanks, Andrew