Re: [U-Boot] [PATCH] Freescale t104x: Do not exclude SGMII

On 10/24/2014 07:49 AM, Joakim Tjernlund wrote:

fman_port_enet_if() tests if FM1_DTSEC2 or FM1_DTSEC4 uses RGMII or MII and if not returns PHY_INTERFACE_MODE_NONE. This excludes testing for SGMII further down.

Remove the unconditional "else return PHY_INTERFACE_MODE_NONE" so SGMII can be tested too.

Signed-off-by: Joakim Tjernlund Joakim.Tjernlund@transmode.se

drivers/net/fm/t1040.c | 4 ---- 1 file changed, 4 deletions(-)

diff --git a/drivers/net/fm/t1040.c b/drivers/net/fm/t1040.c index 4cce46d..d2a097e 100644 --- a/drivers/net/fm/t1040.c +++ b/drivers/net/fm/t1040.c @@ -25,8 +25,6 @@ phy_interface_t fman_port_enet_if(enum fm_port port) else if ((rcwsr13 & FSL_CORENET_RCWSR13_EC1) == FSL_CORENET_RCWSR13_EC1_FM1_DTSEC4_MII) return PHY_INTERFACE_MODE_MII;

• else
  

• 	return PHY_INTERFACE_MODE_NONE;
  

  }

  if ((port == FM1_DTSEC4) &&

@@ -38,8 +36,6 @@ phy_interface_t fman_port_enet_if(enum fm_port port) else if ((rcwsr13 & FSL_CORENET_RCWSR13_EC1) == FSL_CORENET_RCWSR13_EC1_FM1_DTSEC4_MII) return PHY_INTERFACE_MODE_MII;

• else
  

• 	return PHY_INTERFACE_MODE_NONE;
  

  }

  if (port == FM1_DTSEC5) {

Prabhakar,

Can you test/ack this patch?

York