Dear Wolfgang Wegner,
In message 1256914121-26044-1-git-send-email-w.wegner@astro-kom.de you wrote:
write_buff_nb() introduces quite an amount of duplicate code compared to write_buff(), but I did not find an elegant solution to partition them.
Signed-off-by: Wolfgang Wegner w.wegner@astro-kom.de
drivers/mtd/cfi_flash.c | 440 ++++++++++++++++++++++++++++++++++++++--------- include/flash.h | 3 + 2 files changed, 365 insertions(+), 78 deletions(-)
This summary alone is a pretty clear message to me. This is indeed a lot of added, and even worse, duplicated code.
I see currently no reason to change my mind: I don;t want to see this code in mainline. It breaks with the design principles, and makes the common code more difficult to maintain with no benefit for the majority of the users.
Sorry.
Best regards,
Wolfgang Denk