Commit 505be87 - NET: Proper return code handling in eth_init() function in file eth.c
Signed-off-by: Emil Medve Emilian.Medve@Freescale.com ---
Resending as the previous e-mail had a bad header
drivers/qe/uec.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c index dc2765b..d7d7ccc 100644 --- a/drivers/qe/uec.c +++ b/drivers/qe/uec.c @@ -1110,7 +1110,7 @@ static int uec_init(struct eth_device* dev, bd_t *bd) if (dev->enetaddr[0] & 0x01) { printf("%s: MacAddress is multcast address\n", __FUNCTION__); - return 0; + return -EINVAL; } uec_set_mac_address(uec, dev->enetaddr); uec->the_first_run = 1; @@ -1119,10 +1119,10 @@ static int uec_init(struct eth_device* dev, bd_t *bd) err = uec_open(uec, COMM_DIR_RX_AND_TX); if (err) { printf("%s: cannot enable UEC device\n", dev->name); - return 0; + return err; }
- return uec->mii_info->link; + return !uec->mii_info->link; }
static void uec_halt(struct eth_device* dev)