Hi Simon,
Hi,
On 29 May 2014 09:58, Stephen Warren swarren@wwwdotorg.org wrote:
On 05/23/2014 06:51 PM, Simon Glass wrote:
Hi Lukasz,
On 22 May 2014 00:43, Lukasz Majewski l.majewski@samsung.com wrote:
This commit adds test script for testing if any commit has introduced regression to the DFU.
It uses md5 to test if sent and received file is correct. The test detailed description is available at DESCRIPTION.TXT file.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com
test/dfu/DESCRIPTION.TXT | 27 ++++++++++++++
diff --git a/test/dfu/DESCRIPTION.TXT b/test/dfu/DESCRIPTION.TXT new file mode 100644 index 0000000..48da06b --- /dev/null +++ b/test/dfu/DESCRIPTION.TXT @@ -0,0 +1,27 @@ +DFU TEST CASE DESCRIPTION:
+For running test script one needs to create: +./log and ./bkp
+One also need to generate with dd following files:
+dat_*
+(e.g. dat_127B.img dat_128B.img dat_129B.img dat_33M.img dat_4095B.img +dat_4096B.img dat_4097B.img dat_63B.img dat_64B.img dat_65B.img +dat_960.img dat_97M.img)
How do you do that? Is this intended for use with a particular board? I think you are missing some info here.
I think the test script should generate its own test files, so the user can simply run it without having to manually set up a bunch of stuff first.
Agreed. As a general rule it would be good if the tests would run through all possible options and not require user involvement. I'm not sure if that is possible in this case though.
I could provide a special script to automatize the work. Either in the script itself or via configuration file it could be possible to specify files' size to be used. Running this script would assure that each user would have the same environment.
One important test-case is files that are larger than CONFIG_SYS_DFU_DATA_BUF_SIZE. Is dat_97M.img above intended to be 97MB? If so, that's probably covered. Testing large sizes that both are and are-not multiples of CONFIG_SYS_DFU_DATA_BUF_SIZE would be useful.
Yes, this is the case.
Regards, Simon