On Fri, 2020-03-06 at 15:14 +0100, Stefan Roese wrote:
The current implementations have some issues detecting the correct values:
dqs_find_max() will return "last passing fieldval + 1" instead of "last passing fieldval". Also it will return "maxval + 1" in the case that all fieldvals are tested valid (without error).
dqs_find_min() will not test the "lowest" value because of using ">" instead of ">=".
This patch now rewrites these functions to fix those issues. Also, this patch uses the same approach of a for loop in both functions making it easier to read and maintain.
Since the variables are integers now, we can use min()/max(), which handles the wrap around case for fieldval=0: return (0 - 1).
Signed-off-by: Stefan Roese sr@denx.de Cc: Weijie Gao weijie.gao@mediatek.com Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com
arch/mips/mach-mtmips/ddr_cal.c | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-)
Reviewed-by: Weijie Gao weijie.gao@mediatek.com