On 01/13/2011 06:15 PM, Marek Vasut wrote:
- mxc_request_iomux(MX51_PIN_NANDF_RB3, IOMUX_CONFIG_GPIO);
- mxc_iomux_set_pad(MX51_PIN_NANDF_RB3, PAD_CTL_100K_PU);
- mxc_gpio_direction(IOMUX_TO_GPIO(MX51_PIN_NANDF_RB3),
MXC_GPIO_DIRECTION_IN); + rev |= (!!mxc_gpio_get(IOMUX_TO_GPIO(MX51_PIN_NANDF_RB3))) << 2;
Is it ok to leave the NAND pins configured as GPIO, or should they set back for the NFC controller ?
I don't think there is even NAND used on efikamx. Though I might be mistaken.
Understood, then I agree to leave the iomux set with gpios.
Replace fix constants with defines, adding them to mc13892.h if they are missing.
Is any sane datasheet for this thing available ? If so, can you link me to it please?
There is a datasheet, I do not know if you can consider it "sane" ;-)
http://cache.freescale.com/files/analog/doc/data_sheet/MC13892.pdf?fpsp=1
The register description is quite spread in the manual. You can see the complete SPI Bitmap on pages 118-121.
I have already set most constants in include/mc13892.h, probably there are some missing.
+#define __io
I think we have already discussed abot this define. Should it not move to another file, such as imx-regs.h ? Or is there a better solution ?
The thread where we discussed this got deaf. I tried asking further, but no reply :-(
Agree, I remember the issue, I do not remember any decision. Anyway, I think the position of this macro is wrong. It is related to the processor, that can have it or not, and it is not related to the board. I see that in u-boot __io is defined in board configuration file, but I do not think it is correct.
At least I will suggest to move this define in the processor related file (-->imx-regs.h).
Cheers, Stefano