
14 Oct
2011
14 Oct
'11
9:29 p.m.
Dear Simon Glass,
In message 1318552994-6653-2-git-send-email-sjg@chromium.org you wrote:
--- a/include/common.h +++ b/include/common.h
...
+/**
- Decode the value of an environment variable and return it.
- @param name Name of environemnt variable
- @param base Number base to use (normally 10, or 16 for hex)
- @param default_val Default value to return if the variable is not
found
- @return the decoded value, or default_val if not found
- */
Please don't add such documentation to common.h (especially not when it breaks the coding style for multiline comments).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Just Say No." - Nancy Reagan
"No." - Ronald Reagan