Hello Minkyu Kang,
On Thu, Nov 20, 2014 at 12:41 AM, Minkyu Kang mk7.kang@samsung.com wrote:
Dear Suriyan Ramasami,
On 20/11/14 01:21, Suriyan Ramasami wrote:
The USB host code was missing gpio_request() calls before using the gpio functions, causing errors to be printed out.
Signed-off-by: Suriyan Ramasami suriyan.r@gmail.com
Changes in v1:
- Added gpio_request() call in board_gpio_init()
board/samsung/odroid/odroid.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c index f7396ab..a2c008e 100644 --- a/board/samsung/odroid/odroid.c +++ b/board/samsung/odroid/odroid.c @@ -382,6 +382,17 @@ static void board_gpio_init(void) gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP); gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X); gpio_direction_input(EXYNOS4X12_GPIO_X31);
+#ifdef CONFIG_CMD_USB
/* USB3503A Reference frequency */gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq");/* USB3503A Connect */gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect");/* USB3503A Reset */gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset");+#endif }
static int pmic_init_max77686(void) @@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init)
p_pmic = pmic_get("MAX77686_PMIC"); if (p_pmic && !pmic_probe(p_pmic)) {
max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF); max77686_set_buck_voltage(p_pmic, 8, 750000); max77686_set_buck_voltage(p_pmic, 8, 3300000);max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);why you remove those two lines? This patch is for adding gpio_request call, and there's no explain for this change.
Sorry about the confusion caused. This topic was discussed in another thread, and I shall add the comments (from Przemyslaw) in the next version as to why the BUCK OFF and ON does not work as expected on the Odroid boards.
Regards - Suriyan
Thanks, Minkyu Kang.