Re: [PATCH v4 3/3] sunxi: Use mkimage for SPL boot image generation

On 07/01/2021 12:36, Simon Glass wrote:

Hi Simon,

thanks for the review!

On Wed, 6 Jan 2021 at 02:25, Andre Przywara andre.przywara@arm.com wrote:

...

Switch the SPL boot image generation from using mksunxiboot to the new sunxi_egon format of mkimage.

Verified to create identical results for all 152 Allwinner boards.

Signed-off-by: Andre Przywara andre.przywara@arm.com

scripts/Makefile.spl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

Do we need to delete the old tool?

I would rather not quite do this yet, instead leave it around for a bit. There is for instance sunxi-tools, that relies on this, and it's also packaged as part of Debian's u-boot-tools package. We surely will transition them over, but this might take a while.

Cheers, Andre