On 12:22-20220202, Hari Nagalla wrote:
One additional comment independent of Christian's comment..
[...]
diff --git a/arch/arm/mach-k3/am642_init.c b/arch/arm/mach-k3/am642_init.c index 543dea02bc..cb9495e525 100644 --- a/arch/arm/mach-k3/am642_init.c +++ b/arch/arm/mach-k3/am642_init.c @@ -24,6 +24,8 @@ #include <dm/root.h>
#if defined(CONFIG_SPL_BUILD) +#define MCU_CTRL_MMR0_BASE 0x04500000 +#define CTRLMMR_MCU_RST_CTRL 0x04518170
static void ctrl_mmr_unlock(void) { @@ -42,6 +44,17 @@ static void ctrl_mmr_unlock(void) mmr_unlock(MCU_PADCFG_MMR1_BASE, 1); }
+static void mcu_ctrl_mmr_unlock(void) +{
There is no real point in spliting this up into mcu_ctrl_mmr_unlock. I'd suggest putting it part of ctrl_mmr_unlock (we already do unlock MCU padconf mmrs there)
[...]