Dne Čt 1. července 2010 05:33:46 Marek Vasut napsal(a):
Dne Čt 1. července 2010 02:44:01 Albert ARIBAUD napsal(a):
Le 01/07/2010 02:09, Marek Vasut a écrit :
common/cmd_ide.c | 22 +++++++++++++--------- 1 files changed, 13 insertions(+), 9 deletions(-)
I don't see the big advantage of this patch yet.
It won't compile at least on ARM. Same case as with the dm9000 ethernet adapter.
What are the exact advantages of your version?
That it actually compiles and works on other architectures than ppc.
Any updates ?
Actually I've compiled cmd_ide.c for ARM -- I just sent a patchset for this. Required me to #define __io in my board's config,
Are you really supposed to #define __io in your config ?! I doubt that.
Bump? After some discussion with Wolfgang, we figured that'd be the easiest temporary solution actually. But after I tried this approach, I git this problem:
u-boot-pxa/arch/arm/lib/eabi_compat.o -L /usr/lib/gcc/arm-linux-gnueabi/4.4.4 - lgcc -Map u-boot.map -o u-boot common/libcommon.a(cmd_ide.o): In function `output_data': /home/marex/PalmLD/u-boot-pxa/common/cmd_ide.c:904: undefined reference to `__raw_writesw' common/libcommon.a(cmd_ide.o): In function `input_data': /home/marex/PalmLD/u-boot-pxa/common/cmd_ide.c:962: undefined reference to `__raw_readsw' /home/marex/PalmLD/u-boot-pxa/common/cmd_ide.c:962: undefined reference to `__raw_readsw' make: *** [u-boot] Error 1
So arm is missing the implementation of __raw_reads[bwl] etc.
and also to #define CONFIG_IDE_SWAP_IO, a new configuration option which replaces the complex conditionals on __PPC__ et al.
Amicalement,