Re: [U-Boot] [PATCH] DaVinci DA8xx: fix set_cpu_clk_info()

On Sat, Jul 28, 2012 at 12:49:55PM +0530, Prabhakar Lad wrote:

Thanks for the patch. I have tested this patch, below are few comments.

[snip]

...

+int set_cpu_clk_info(void) +{

•   gd->bd->bi_arm_freq = clk_get(DAVINCI_ARM_CLKID) / 1000000;
  

•   /* DDR PHY uses an x2 input clock */
  

•   gd->bd->bi_ddr_freq = clk_get(0x10001) / 1000000;
  

 Can you define a macro for this 0x10001 ?

With that change you can add my ACK:

Acked-by: Prabhakar Lad prabhakar.lad@ti.com

Hi Prabhakar,

I have tidied up the clock IDs a little and added a constant for the DDR2 clock ID as you suggested. It made sense that this would be a separate set of patches:

http://lists.denx.de/pipermail/u-boot/2012-July/129444.html

Bye for now,