On 03/01/2012 03:17 AM, Orjan Friberg wrote:
On 02/29/2012 10:00 PM, Scott Wood wrote:
ECC mode is normally not something that you want to be runtime switchable, as changing it usually changes the on-flash format. It also requires driver cooperation -- the actual implementation (as opposed to the command-line wrapper) is in drivers/mtd/nand/omap_gpmc.c.
Are you saying that it shouldn't be switchable through a command line option (but rather based on information in the partition table or something similar), or are you saying that we shouldn't need different ECC modes for different parts of the flash (boot ROM vs. software implementations, whether block 0 has different ECC requirement etc)?
I'm saying that right now it's an OMAP-specific requirement and the implementation of necessity involves the OMAP driver. If another driver grows this as a requirement, we can consider refactoring so the command line frontend is common.
Different ECC modes for different parts of the flash is unfortunate, but sometimes mandated by circumstance. The NAND subsystem isn't really set up to handle this, though changing it temporally is a hackish substitute.
-Scott