22 May
2012
22 May
'12
5:51 p.m.
Dear Amit Virdi,
In message 4FBB6712.3040005@st.com you wrote:
Alright, I shall be soon sending V5 that drops this patch and uses __change_bit directly.
It would be a much better investment in time if you come up with patches that help to _avoid_ usign this horrible function, and eventually removig it from U-Boot.
change_bit() is inherently not portable and actual behaviour is largely undefined, so please do NOT use this function in any new code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Immortality consists largely of boredom.
-- Zefrem Cochrane, "Metamorphosis", stardate 3219.8