Hi Tom,
I've attached version 2 of the patch. I believe this should adhere more closely to your suggestions.
Keep in mind, CONFIG_IS_ENABLED will not work for checking CMD_BOOTI/CMD_BOOTZ in this case, as there is no CONFIG_SPL_CMD_BOOTx. So, I'm just directly checking if it's defined instead.
I verified both CONFIG_IS_ENABLED() and IS_ENABLED() did not work.
Sincerely, Nathan
On Mon, Jan 31, 2022 at 10:35 AM Tom Rini trini@konsulko.com wrote:
On Mon, Jan 31, 2022 at 10:23:58AM -0500, Nathan Barrett-Morrison wrote:
Hi Tom,
Yea, I'm not sure if uncompressed ARM32 would work, but I don't believe
it
was ever working to begin with... as bootz_setup is being called right
now
( @
https://source.denx.de/u-boot/u-boot/-/blob/master/common/spl/spl.c#L366
)
My intent was for SPL_OS_BOOT_UNCOMPRESSED to only be used for platforms which need booti_setup (ARM64, ...).
So... I could add a dependency on ARM64 in the config option or I could remove the option altogether and let the booti_setup fail and fallback to bootz_setup. Would either of those work for you?
The code and logic overall needs a bit of refactoring to support "booti", "bootz" and also FIT images. I believe FIT images are how anyone doing falcon mode on arm64 has worked thus far. booti/bootz should only be an option when CMD_BOOTI/Z is set, and FIT should depend on SPL_LOAD_FIT already.
-- Tom