Re: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask property

On Mon, 22 Jun 2020 at 23:30, Bin Meng bmeng.cn@gmail.com wrote:

From: Bin Meng bin.meng@windriver.com

Per the DT binding, <offset> is a required property. Let's abort the probe if it is missing. For the <mask> property, current codes assume a default value of zero, which is not correct either.

Signed-off-by: Bin Meng bin.meng@windriver.com

drivers/sysreset/sysreset_syscon.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org